Compare commits

...
3 Commits
Author SHA1 Message Date
Patryk-Kuchta a18189dcea Merge pull request 'fix: upgrade Node to 24 so the Docker build works with sharp 0.35' (#3) from fix-docker-node-24 into main
Security Audit / Security Vulnerability Scan (push) Successful in 20s
Code Quality Check / Lint & Type Check (push) Successful in 23s
Reviewed-on: #3
2026-10-19 18:40:04 +00:00
Patryk-KuchtaandClaude Opus 5 9c597cbc80 fix: install pnpm via corepack in CI
Code Quality Check / Lint & Type Check (pull_request) Successful in 19s
Security Audit / Security Vulnerability Scan (pull_request) Successful in 19s
pnpm/action-setup's self-installer fails on Node 24 ("Running
self-installer..." exits 1), breaking both workflows. Use corepack
instead, which picks up the pnpm version from the packageManager field
and matches how the Dockerfile installs it.

Also move upload-artifact to v4, since v3 is retired.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-10-19 19:39:16 +01:00
Patryk-KuchtaandClaude Opus 5 ab7b2fa6f4 fix: upgrade Node to 24 so the Docker build works with sharp 0.35
Security Audit / Security Vulnerability Scan (pull_request) Failing after 13s
Code Quality Check / Lint & Type Check (pull_request) Failing after 13s
sharp 0.35.5 requires Node >=20.9.0, so the node:18-alpine image failed
to load the linuxmusl-arm64 binary and the production build broke.

Move the image and both CI workflows to Node 24 (current Active LTS),
raise the engines floor to the version sharp actually needs, and declare
packageManager to silence the corepack warning.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-10-19 19:37:21 +01:00
4 changed files with 8 additions and 11 deletions

No files matched your search

+3 -5
View File
@@ -26,12 +26,10 @@ jobs:
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v4
with: with:
node-version: '18' node-version: '24'
- name: Setup pnpm - name: Setup pnpm
uses: pnpm/action-setup@v4 run: corepack enable
with:
version: 10
- name: Get pnpm store directory - name: Get pnpm store directory
shell: bash shell: bash
@@ -60,7 +58,7 @@ jobs:
run: pnpm outdated || true run: pnpm outdated || true
- name: Upload security report - name: Upload security report
uses: actions/upload-artifact@v3 uses: actions/upload-artifact@v4
if: always() if: always()
with: with:
name: security-report name: security-report
+2 -4
View File
@@ -24,12 +24,10 @@ jobs:
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v4
with: with:
node-version: '18' node-version: '24'
- name: Setup pnpm - name: Setup pnpm
uses: pnpm/action-setup@v4 run: corepack enable
with:
version: 10
- name: Get pnpm store directory - name: Get pnpm store directory
shell: bash shell: bash
+1 -1
View File
@@ -1,4 +1,4 @@
FROM node:18-alpine AS base FROM node:24-alpine AS base
RUN apk add --no-cache libc6-compat RUN apk add --no-cache libc6-compat
RUN corepack enable && corepack prepare [email protected] --activate RUN corepack enable && corepack prepare [email protected] --activate
+2 -1
View File
@@ -2,6 +2,7 @@
"name": "new_portfolio", "name": "new_portfolio",
"version": "0.1.0", "version": "0.1.0",
"private": true, "private": true,
"packageManager": "[email protected]",
"scripts": { "scripts": {
"dev": "next dev -p 4000", "dev": "next dev -p 4000",
"build": "next build", "build": "next build",
@@ -40,7 +41,7 @@
"sass": "^1.105.2" "sass": "^1.105.2"
}, },
"engines": { "engines": {
"node": ">=18.0.0", "node": ">=20.9.0",
"pnpm": ">=8.0.0" "pnpm": ">=8.0.0"
}, },
"pnpm": { "pnpm": {